Skip to content

KEYS-38938 [Core] Simplified OTPs, security, and rate limiting - #1091

Open
AlexanderVietrov wants to merge 4 commits into
masterfrom
task/KEYS-38938
Open

KEYS-38938 [Core] Simplified OTPs, security, and rate limiting#1091
AlexanderVietrov wants to merge 4 commits into
masterfrom
task/KEYS-38938

Conversation

@AlexanderVietrov

@AlexanderVietrov AlexanderVietrov commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Jira link: KEYS-38938

Notes:

related to #4551

I have a few questions regarding the image attached to the task for the new mail template.

image
  • For anonymous requests, we cannot provide a full name
  • Which link should be used for the “Terms of Use”?
  • Should we make patches to the standard header and footer related to CS layer, or should we use separate templates for this?

@TobiasWolters

Copy link
Copy Markdown
Contributor

@bbedigi Can you maybe assist Alexander here?

@bbedigi

bbedigi commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@bbedigi Can you maybe assist Alexander here?

I can only answer this one: "Should we make patches to the standard header and footer related to CS layer, or should we use separate templates for this?"

  • The header template is fine, it contains only the logo.
  • For the footer, we should split the 'If you have any issue ...' and 'if you don't have an account..' from the footer template and include manually in the assetsharedbyemail.dcl.

The 2 bottom text lines from above don't make sense in our case, they are taken from a signup flow.

@TobiasWolters

TobiasWolters commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
  • For anonymous requests, we cannot provide a full name

If we don't have a name available, let's just write "Hello!".

  • Which link should be used for the “Terms of Use”?

https://www.keyshot.com/legal/keyshot-studio-terms-of-use/

@AlexanderVietrov

Copy link
Copy Markdown
Contributor Author

@TobiasWolters I updated the templates. But I feel like something's missing. The email looks a little strange to me.

@AlexanderVietrov

AlexanderVietrov commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

example:
image

@TobiasWolters

Copy link
Copy Markdown
Contributor

Thanks for looking at it Alexander. Bernadette will have a look 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants